Changeset 45

Timestamp:

04/08/05 18:16:30 (4 years ago)

Author:

ogawa

Message:

Add more sophisticated is_spam interface and logging function

Files:

• quasi-spamfilter/trunk/quasi-spamfilter.pl (modified) (10 diffs)

quasi-spamfilter/trunk/quasi-spamfilter.pl

@@ -1 +1 @@
 # A plugin for filtering Comment and TBPing Spams
 #
-# Release 0.18 (Mar 6, 2005)
+# Release 0.20 (Apr 8, 2005)
 #
 # This software is provided as-is. You may use it for commercial or 
@@ -8 +8 @@
 # Copyright (c) 2005 Hirotaka Ogawa
 
+package MT::Plugin::Quasi_SpamFilter;
 use strict;
-use vars qw($COMMENT_PATTERN $TBPING_PATTERN $COMMENT_METHOD $TBPING_METHOD
+use vars qw($COMMENT_PATTERN $COMMENT_METHOD
+            $TBPING_PATTERN $TBPING_METHOD
+            $ENABLE_LOGGING
             $URL %comment_methods %tbping_methods);
 
@@ -19 +22 @@
 # 'CommentFilter', 'CommentThrottleFilter', 'CommentError',
 # 'CommentLongError', 'CommentRedirect', 'CommentEvilRedirect'
-$COMMENT_METHOD = 'CommentFilter';
+$COMMENT_METHOD = 'CommentError';
 
 # Choose a method for rejecting Spam Pings from:
 # 'TBPingFilter', 'TBPingThrottleFilter', 'TBPingError'
-$TBPING_METHOD = 'TBPingFilter';
+$TBPING_METHOD = 'TBPingError';
 
 # Set your Redirect URL (for 'CommentRedirect' and 'CommentEvilRedirect')
 $URL = 'http://www.2ch.net/';
+
+# Enable logging? (1/0)
+$ENABLE_LOGGING = 1;
 
 eval("use Storable;");
@@ -32 +38 @@
     require MT::Plugin;
     my $plugin = new MT::Plugin();
-    $plugin->name("Quasi Spam Filter Plugin, v.0.18");
+    $plugin->name("Quasi Spam Filter Plugin 0.20");
     $plugin->description("A Simple filter for Comment & TBPing Spams");
     $plugin->doc_link("http://as-is.net/hacks/2005/01/quasi_spam_filter_plugin.html");
@@ -69 +75 @@
 }
 
+use MT::Comment;
+use MT::TBPing;
+
 sub is_comment_spam {
-    my $text = shift;
-    return ($text =~ /$COMMENT_PATTERN/i);
+    my $comment = shift;
+    return ($comment->text =~ /$COMMENT_PATTERN/i);
 }
 
 sub is_tbping_spam {
-    my $text = shift;
-    return ($text =~ /$TBPING_PATTERN/i);
+    my $tbping = shift;
+    return ($tbping->excerpt =~ /$TBPING_PATTERN/i);
+}
+
+sub _make_pseudo_comment {
+    my $app = shift;
+    my $q = $app->{query};
+    my $comment = MT::Comment->new;
+    $comment->author($q->param('author') || '');
+    $comment->email($q->param('email') || '');
+    $comment->url($q->param('url') || '');
+    $comment->text($q->param('text') || '');
+    $comment->ip($app->remote_ip || '');
+    return $comment;
+}
+
+sub _make_pseudo_tbping {
+    my $app = shift;
+    my $q = $app->{query};
+    my $tbping = MT::TBPing->new;
+    $tbping->title($q->param('title') || '');
+    $tbping->excerpt($q->param('excerpt') || '');
+    $tbping->source_url($q->param('url') || '');
+    $tbping->blog_name($q->param('blog_name') || '');
+    $tbping->ip($app->remote_ip || '');
+    return $tbping;
 }
 
 sub comment_filter {
     my ($eh, $app, $comment) = @_;
-    return !is_comment_spam($comment->text);
+    if (is_comment_spam($comment)) {
+        $app->log("[QSF] drop a spam comment from " . $comment->author) if $ENABLE_LOGGING;
+        return 0;
+    }
+    return 1;
 }
 
 sub comment_throttle_filter {
     my ($eh, $app, $entry) = @_;
-    my $comment = $app->{query}->param('text');
-    return !is_comment_spam($comment);
+    my $comment = _make_pseudo_comment($app);
+    if (is_comment_spam($comment)) {
+        $app->log("[QSF] drop a spam comment from " . $comment->author) if $ENABLE_LOGGING;
+        return 0;
+    }
+    return 1;
 }
 
@@ -95 +136 @@
     my $mode = $q->param('__mode') || $app->{default_mode};
     return if $mode ne 'post';
-    if (is_comment_spam($q->param('text'))) {
-        $app->add_methods(post => sub { });
-        $app->error("Spam Comment!");
+    my $comment = _make_pseudo_comment($app);
+    if (is_comment_spam($comment)) {
+        $app->add_methods(post => sub { });
+        $app->error("Spam Comment!");
+        $app->log("[QSF] drop a spam comment from " . $comment->author) if $ENABLE_LOGGING;
     }
 }
@@ -106 +149 @@
     my $mode = $q->param('__mode') || $app->{default_mode};
     return if $mode ne 'post';
-    if (is_comment_spam($q->param('text'))) {
-        $app->add_methods(post => sub { $_[0]->handle_error("Spam Comments!") });
+    my $comment = _make_pseudo_comment($app);
+    if (is_comment_spam($comment)) {
+        $app->add_methods(post => sub { $_[0]->handle_error("Spam Comments!") });
+        $app->log("[QSF] drop a spam comment from " . $comment->author) if $ENABLE_LOGGING;
     }
 }
@@ -116 +161 @@
     my $mode = $q->param('__mode') || $app->{default_mode};
     return if $mode ne 'post';
-    if (is_comment_spam($q->param('text'))) {
-        $app->add_methods(post => sub { });
-        $app->redirect($URL);
+    my $comment = _make_pseudo_comment($app);
+    if (is_comment_spam($comment)) {
+        $app->add_methods(post => sub { });
+        $app->redirect($URL);
+        $app->log("[QSF] drop a spam comment from " . $comment->author) if $ENABLE_LOGGING;
     }
 }
@@ -127 +174 @@
     my $mode = $q->param('__mode') || $app->{default_mode};
     return if $mode ne 'post';
-    if (is_comment_spam($q->param('text'))) {
-        $app->add_methods(post => sub { });
-        $app->redirect($q->param('url') || $URL);
+    my $comment = _make_pseudo_comment($app);
+    if (is_comment_spam($comment)) {
+        $app->add_methods(post => sub { });
+        $app->redirect($q->param('url') || $URL);
+        $app->log("[QSF] drop a spam comment from " . $comment->author) if $ENABLE_LOGGING;
     }
 }
 
 sub tbping_filter {
-    my ($eh, $app, $ping) = @_;
-    return !is_tbping_spam($ping->excerpt);
+    my ($eh, $app, $tbping) = @_;
+    if (is_tbping_spam($tbping)) {
+        $app->log("[QSF] drop a spam tbping from " . $tbping->blog_name) if $ENABLE_LOGGING;
+        return 0;
+    }
+    return 1;
 }
 
 sub tbping_throttle_filter {
     my ($eh, $app, $tb) = @_;
-    my $q = $app->{query};
-    return !is_tbping_spam($q->param('excerpt'));
+    my $tbping = _make_pseudo_tbping($app);
+    if (is_tbping_spam($tbping)) {
+        $app->log("[QSF] drop a spam tbping from " . $tbping->blog_name) if $ENABLE_LOGGING;
+        return 0;
+    }
+    return 1;
 }
 
@@ -149 +206 @@
     my $mode = $q->param('__mode') || $app->{default_mode};
     return if $mode ne 'ping';
-    if (is_tbping_spam($q->param('excerpt'))) {
+    my $tbping = _make_pseudo_tbping($app);
+    if (is_tbping_spam($tbping)) {
         $app->add_methods('ping' => sub { });
         $app->_response(Error => 'Spam TBPing!', Code => 403);
+        $app->log("[QSF] drop a spam tbping from " . $tbping->blog_name) if $ENABLE_LOGGING;
     }
 }